This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Re-disable iOS Scenarios tests due to flakiness #21123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts flutter#21087, which speculatively re-enabled the Scenarios iOS tests once we'd got Dart/Skia/Fuchsia rolls in, which had been blocked by flaky test runs. We'd hoped that that PR would be sufficient to eliminate the tree closures but new tests within the suite started failing instead. Reverting while the issue is root-caused and fixed. Related P0 issue: flutter/flutter#61620 This reverts commit bdaac36.
gaaclarke
approved these changes
Sep 11, 2020
cbracken
changed the title
|
I've landed #21125, which is a less drastic take on this, in hopes that that'll do it for now. |
|
Closing since it looks like #21107 has resolved this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #21087, which speculatively re-enabled the Scenarios iOS
tests once we'd got Dart/Skia/Fuchsia rolls in, which had been blocked
by flaky test runs. We'd hoped that that PR would be sufficient to
eliminate the tree closures but new tests within the suite started
failing instead. Reverting while the issue is root-caused and fixed.
Related P0 issue: flutter/flutter#61620
This reverts commit bdaac36.