Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Account for current open image in FlutterImageView #21191

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

blasten
Copy link

@blasten blasten commented Sep 15, 2020

Description

My previous patch didn't account for the fact that the image remains open after it's dequeued, so there's a bug in the current implementation. I updated the test to account for this case.

Related Issues

Fixes flutter/flutter#63897

Tests

Unit test

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 15, 2020
@blasten blasten merged commit 1ef10b2 into flutter:master Sep 15, 2020
@blasten blasten deleted the max_images branch September 15, 2020 21:11
pcsosinski pushed a commit to pcsosinski/engine that referenced this pull request Sep 15, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 15, 2020
pcsosinski pushed a commit that referenced this pull request Sep 15, 2020
* Update 1.22 engine to use Dart 2.10.0-110.3.beta

* Add a new raster status `kSkipAndRetry` frame (#21059)

* update license file for Dart 2.10.0-110.3.beta

* Account for current open image in FlutterImageView (#21191)

Co-authored-by: Emmanuel Garcia <[email protected]>
@imReker
Copy link

imReker commented Oct 19, 2020

Any further update?
FlutterImageView do not check it's size and call flutterRenderer.startRenderingToSurface/surfaceChanged like FlutterSurfaceView or FlutterTextureView, and this makes blank screen if use it directly to create a FlutterView.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] App Crashes after adopting Hybrid Composition
4 participants