This repository was archived by the owner on Feb 25, 2025. It is now read-only.
IME Animation clean up extraneous window inset call #21213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
GaryQian
commented
Sep 16, 2020
shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java
Outdated
Show resolved
Hide resolved
xster
reviewed
Sep 16, 2020
| @@ -199,7 +199,8 @@ public void sendAppPrivateCommand(String action, Bundle data) { | |||
|
|
|||
| private View view; | |||
| private WindowInsets lastWindowInsets; | |||
| private boolean started = false; | |||
| private boolean animating = false; | |||
There was a problem hiding this comment.
I'd add code comments for what these 2 are for the next maintainer
| @@ -212,34 +213,35 @@ public void sendAppPrivateCommand(String action, Bundle data) { | |||
| @Override | |||
| public WindowInsets onApplyWindowInsets(View view, WindowInsets windowInsets) { | |||
| this.view = view; | |||
| if (started) { | |||
| if (needsSave) { | |||
| // Store the view and insets for us in onEnd() below | |||
There was a problem hiding this comment.
You described the what, but didn't describe the why (saving is needed) :)
| @@ -677,6 +677,10 @@ public void ime_windowInsetsSync() { | |||
| builder.setInsets(WindowInsets.Type.navigationBars(), Insets.of(10, 10, 10, 40)); | |||
| WindowInsets imeInsets1 = builder.build(); | |||
There was a problem hiding this comment.
add some comments for what 0, 1, 2 are supposed to represent? Different stages of an animation?
GaryQian
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
|
Landing, Linux Web Engine passes on rerun: https://ci.chromium.org/p/flutter/builders/try/Linux%20Web%20Engine/9773 |
GaryQian
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2020
|
removing cp label from PR in favor of the issue |
christopherfujino
added a commit
that referenced
this pull request
Sep 24, 2020
* Update 1.22 engine to use Dart 2.10.0-110.5.beta * Dark mode friendly iOS debugging message (#21277) * Update FlutterViewController.mm (#21362) * Tweaked the label here a little for style ("apps", not "application" -- plural and shorter); and "launching" rather than "re-launching"? * Fix iOS platform view's mask view blocking touch events. (#21286) * Disconnect the view's AndroidKeyProcessor when detaching from the engine (#21307) * Remove extraneous window inset call on IME animation (#21213) * Retain the WindowInsetsAnimation callback if code shrinking is enabled (#21330) Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Tim Sneath <[email protected]> Co-authored-by: Chris Yang <[email protected]> Co-authored-by: Jason Simmons <[email protected]> Co-authored-by: Gary Qian <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug part of flutter/flutter#65821
onStartis called too late, which resulted in one of the final IME position calls to slip through. This PR switches to theonPrepareinstead and adds some additional safeguarding to prevent overwriting the saved inset. This is consistent with https://github.com/android/user-interface-samples/blob/master/WindowInsetsAnimation/app/src/main/java/com/google/android/samples/insetsanimation/RootViewDeferringInsetsCallback.kt which also usesonPrepareand is what this is roughly based on.