Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Define SK_VULKAN for clang-tidy runs (#21927)" #22012

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Revert "Define SK_VULKAN for clang-tidy runs (#21927)" #22012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ci/bin/lint.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ https://github.com/flutter/flutter/wiki/Engine-Clang-Tidy-Linter

const String issueUrlPrefix = 'https://github.com/flutter/flutter/issues';

/// Symbol definitions passed to clang-tidy.
const List<String> clangTidyDefineArgs = <String>[
"-DSK_VULKAN", // See: https://github.com/flutter/flutter/issues/68331
];

class Command {
Directory directory = Directory('');
String command = '';
Expand All @@ -51,7 +46,6 @@ String calcTidyArgs(Command command) {
String result = command.command;
result = result.replaceAll(RegExp(r'\S*clang/bin/clang'), '');
result = result.replaceAll(RegExp(r'-MF \S*'), '');
result += ' ' + clangTidyDefineArgs.join(' ');
return result;
}

Expand Down
2 changes: 2 additions & 0 deletions vulkan/vulkan_window.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// FLUTTER_NOLINT: https://github.com/flutter/flutter/issues/68331

#include "vulkan_window.h"

#include <memory>
Expand Down