fuchsia: Reliably pass View insets #25381
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@dreveman @chaselatta Ping on review. |
|
Did you get the right name when you added me as a reviewer? I work on the widget framework not the engine, so I don't feel I am the best person to review this. |
|
Hard to see what is the fix and what is code refactoring. Would it be enough to add and use ResizeViewProperties? I would prefer the fix and refactor as different commits so it's easier to understand. Ideally the refactor as a completely different PR. |
Oh man, my apologies! Wrong Darren! |
arbreng
force-pushed
the
fuchsia-view-insets
branch
from
088c0e5 to
8855c7f
Compare
arbreng
changed the title
Take another look now; all of the changes are functional and none are refactor-related |
* aac3658 Roll Skia from 14efdd3d50db to 3010f3d79193 (4 revisions) (flutter/engine#25857) * f45f52f Move path part files to libraries (flutter/engine#25842) * d96669f Roll Skia from 3010f3d79193 to 5276ba274b38 (1 revision) (flutter/engine#25859) * 43994ab Use "blur_sigma" instead of "blur_radius" in Shadow. (flutter/engine#25760) * 74ac010 Roll Dart SDK from 1e3e5efcd47e to 6397e8b91103 (18 revisions) (flutter/engine#25861) * d462cfd Remove flake inducing timeouts (flutter/engine#25847) * 258f63a Roll Skia from 5276ba274b38 to 31fddc376993 (14 revisions) (flutter/engine#25862) * 1bf01a1 fuchsia: Reliably forward View insets (flutter/engine#25381) * 2740062 Roll Skia from 31fddc376993 to 097263bb5089 (1 revision) (flutter/engine#25865) * 4aae6b3 Roll Dart SDK from 6397e8b91103 to ee8eb0a65efa (1 revision) (flutter/engine#25869) * d1f31c7 Roll Skia from 097263bb5089 to 5dfb3f40684b (1 revision) (flutter/engine#25870) * 428ef10 deflake (flutter/engine#25864) * 01b9db8 Roll Dart SDK from ee8eb0a65efa to 8c109a734bdc (1 revision) (flutter/engine#25872) * e623c09 Roll Dart SDK from 8c109a734bdc to b98a1eec5eb5 (1 revision) (flutter/engine#25873) * 7ce6226 Roll Dart SDK from b98a1eec5eb5 to 6ecae204598d (1 revision) (flutter/engine#25874) * 554c24c Roll Skia from 5dfb3f40684b to 5c95bcb48b9b (1 revision) (flutter/engine#25876) * 03bd2e3 Roll Dart SDK from 6ecae204598d to 3cc6cdab8eaf (2 revisions) (flutter/engine#25877) * 53fdd89 Roll Skia from 5c95bcb48b9b to c779d432f336 (1 revision) (flutter/engine#25880) * 98ee65b Roll Skia from c779d432f336 to ff8b52df55ff (2 revisions) (flutter/engine#25881) * d84caa7 Roll Dart SDK from 3cc6cdab8eaf to b8f4018535fa (2 revisions) (flutter/engine#25885) * 156760e Roll Skia from ff8b52df55ff to ec79349bad50 (1 revision) (flutter/engine#25886) * 23cd8e5 Revert the Dart SDK to 1e3e5efcd47edeb7ae5a69e146c8ea0559305a98 (flutter/engine#25887) * 578449f Fix crash when both FlutterFragmentActivity and FlutterFragment are destroyed and recreated (flutter/engine#25851)
This CL allows view insets / occlusion hint to be set from Dart code with both legacy and platform views paths.
The legacy View code has some confusing code-paths, and this results in it always stomping the view insets with 0's. Fix this bug, and make the ViewHolder's properties write-only to avoid confusion like this in the future.
Second, add support for setting the occlusion hint to the new embedder renderer and new platform views path. This requires parsing the occlusion hint from the "View.update" message and plumbing it through.
Fixes: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=73596