Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

WINUWP: Conditionalize plugin related wrapper #25540

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

clarkezone
Copy link

Add missing conditionalization into relevant plugin header to enable a plugin to correctly compile in the winuwp context where there is no WNDPROC.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@clarkezone clarkezone added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 11, 2021
@fluttergithubbot fluttergithubbot merged commit 4bc4143 into flutter:master Apr 12, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2021
duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes platform-windows waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants