-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
cc @cbracken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one API nit, other than that, this looks good to me!
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied a quick one-line format fix. Looks great -- thanks! A lot of people will be excited to see this land! Apologies for the delay in getting to this; was out of the office for a bit. |
Thanks for your reviewing. (and I'm sorry I forgot to format code.) I'm excited too! |
983ba8b
to
25c4b93
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Rebased and pushed to pick up the same API key change as last time. |
* 1b5b3c0 Roll Skia from 43264640f256 to 791c0d36a6f6 (2 revisions) (flutter/engine#28909) * d3f17b0 Mirror master to main branch. (flutter/engine#28896) * 8f96492 Roll Dart SDK from f452a6585cbd to 280a0c3efb21 (1 revision) (flutter/engine#28910) * 0aee3c6 Roll Skia from 791c0d36a6f6 to 0f124cd7cd60 (2 revisions) (flutter/engine#28911) * bd250bd Windows: Add dark theme support. (flutter/engine#28131)
This PR adds the dark theme support for both windows and winuwp engine, based on flutter/flutter#54612. On Win32: using a registry value that is not documented. (I tested on Windows 10.0.19043.1165) On UWP: using default background color. (I couldn't find WinRT API that returns dark/light directly, without xaml package.) Flutter PR for win32: flutter/flutter#88520. This PR will close flutter/flutter#54612. This PR will complete one item in flutter/flutter#70214.
* 1b5b3c0 Roll Skia from 43264640f256 to 791c0d36a6f6 (2 revisions) (flutter/engine#28909) * d3f17b0 Mirror master to main branch. (flutter/engine#28896) * 8f96492 Roll Dart SDK from f452a6585cbd to 280a0c3efb21 (1 revision) (flutter/engine#28910) * 0aee3c6 Roll Skia from 791c0d36a6f6 to 0f124cd7cd60 (2 revisions) (flutter/engine#28911) * bd250bd Windows: Add dark theme support. (flutter/engine#28131)
This PR adds the dark theme support for both
windows
andwinuwp
engine, based on flutter/flutter#54612.On Win32: using a registry value that is not documented. (I tested on Windows 10.0.19043.1165)
On UWP: using default background color. (I couldn't find WinRT API that returns dark/light directly, without xaml package.)
TODO:
Flutter PR for win32: flutter/flutter#88520.
This PR will close flutter/flutter#54612.
This PR will complete one item in flutter/flutter#70214.
No changes in
flutter/tests
.Pre-launch Checklist
writing and running engine tests.
///
).