This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Add test for external textures on Android #31642
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - This tests are currently not triggered though: flutter/flutter#90401
Hm alright. Hopefully these tests can run in the future, since having some verification for this is very useful. |
I believe this needs a rebase for the tests. |
Any update on the rebase? |
Rebased, sorry for the delay. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 25, 2022
* 0defb26 Add gclient parser. (flutter/engine#32135) * b8ff8f1 Roll impeller to 0ce2e789fc0852d6d9ee63fb68097327447cd7d8 (flutter/engine#32264) * 6096dd1 Add test for external textures on Android (flutter/engine#31642)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (originally #26109) adds three tiers of tests for external texture rendering, along with comparisons for Android's SurfaceView.
Current screenshots show how Flutter's rendering is incorrect, which is what #24888 is supposed to address.
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.