Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Migrate Flutter Web to JS static interop - 4. #32466

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

joshualitt
Copy link
Contributor

This is CL 4 in a series of CLs to migrate Flutter Web to the new JS static interop API.

This CL migrates more of canvaskit_api.dart(about 15% through that file).

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 6, 2022
@joshualitt
Copy link
Contributor Author

@srujzs ptal, nothing fancy, just migrating a number of classes in canvaskit_api.dart

@srujzs
Copy link
Contributor

srujzs commented Apr 7, 2022

LGTM

@joshualitt joshualitt marked this pull request as ready for review April 7, 2022 18:43
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@joshualitt joshualitt requested a review from yjbanov April 7, 2022 18:43
@joshualitt joshualitt requested review from eyebrowsoffire and removed request for yjbanov April 13, 2022 16:47
@Hixie
Copy link
Contributor

Hixie commented Apr 13, 2022

test-exempt: code refactor with no semantic change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs tests platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants