Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Migrate Flutter Web DOM usage to JS static interop - 17. #33338

Merged
merged 13 commits into from
May 23, 2022
Merged

[web] Migrate Flutter Web DOM usage to JS static interop - 17. #33338

merged 13 commits into from
May 23, 2022

Conversation

joshualitt
Copy link
Contributor

This is CL 17 in a series of CLs to migrate Flutter Web DOM usage to the new JS static interop API.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 14, 2022
@skia-gold
Copy link

Gold has detected about 6 new digest(s) on patchset 7.
View them at https://flutter-engine-gold.skia.org/cl/github/33338

@skia-gold
Copy link

Gold has detected about 5 new digest(s) on patchset 7.
View them at https://flutter-engine-gold.skia.org/cl/github/33338

@skia-gold
Copy link

Gold has detected about 6 new digest(s) on patchset 8.
View them at https://flutter-engine-gold.skia.org/cl/github/33338

@skia-gold
Copy link

Gold has detected about 5 new digest(s) on patchset 8.
View them at https://flutter-engine-gold.skia.org/cl/github/33338

@joshualitt joshualitt force-pushed the html_17 branch 2 times, most recently from d867389 to fa97462 Compare May 16, 2022 19:02
@joshualitt joshualitt marked this pull request as ready for review May 18, 2022 21:52
@joshualitt joshualitt requested a review from yjbanov May 18, 2022 21:52
@skia-gold
Copy link

Gold has detected about 6 new digest(s) on patchset 8.
View them at https://flutter-engine-gold.skia.org/cl/github/33338

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #33338 at sha 2b2bc95

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #33338 at sha 96b6620

@joshualitt joshualitt force-pushed the html_17 branch 3 times, most recently from cffc5d7 to 2f8e460 Compare May 20, 2022 01:17
@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #33338 at sha 2f8e460

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #33338 at sha 4dbd364

@joshualitt joshualitt force-pushed the html_17 branch 3 times, most recently from 2ada2ea to 18d7be5 Compare May 20, 2022 22:32
yjbanov
yjbanov approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshualitt joshualitt merged commit c2cb62b into flutter:main May 23, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2022
@engine-flutter-autoroll
c2cb62b [web] Migrate Flutter Web DOM usage to JS static interop - 17. (
9660e85 
flutter/engine#33338)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@joshualitt @houhuayong
[web] Migrate Flutter Web DOM usage to JS static interop - 17. (flutt…
a2a3863 
…er#33338)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
platform-web Code specifically for the web engine will affect goldens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshualitt @skia-gold @yjbanov