This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Support YUV external textures on iOS #36685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
embedder
8 tasks
ColdPaleLight
requested review from
chinmaygarde and
bdero
and removed request for
chinmaygarde
|
@chinmaygarde @bdero The PR is ready for review :) |
chinmaygarde
reviewed
Nov 3, 2022
There was a problem hiding this comment.
Apologies for the delay in this review. Everything looks great except the concern that the OpenGL ES implementation doesn't use ES 2.0 Core features. I haven't explored how to reconcile this limitation ATM. If we can't do this ATM, I'd rather leave the implementation out of this attempt and we can revisit it later during an ES backend polishing effort. Thanks!
| type = GL_UNSIGNED_BYTE; | ||
| break; | ||
| case PixelFormat::kR8G8UNormInt: | ||
| internal_format = GL_RG; |
There was a problem hiding this comment.
I don't believe these are part of OpenGL ES 2.0 are they?
There was a problem hiding this comment.
Good catch! I removed these and add a TODO comment with issue id in the test.
chinmaygarde
approved these changes
Nov 3, 2022
ColdPaleLight
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 4, 2022
…114651) * 3593f34b9 Roll Skia from bddba32af857 to 8e48bb8ea52e (5 revisions) (flutter/engine#37297) * fb7cde697 [Impeller] Support YUV external textures on iOS (flutter/engine#36685)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
* Tweak Texture::Paint API * Support external textures for iOS * format code * Tweak code * format * Clean code * [Impeller] Support YUV external textures on iOS * Fix test * Clean code * Fix compile error * Add todo link * Clean code
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#114651) * 3593f34b9 Roll Skia from bddba32af857 to 8e48bb8ea52e (5 revisions) (flutter/engine#37297) * fb7cde697 [Impeller] Support YUV external textures on iOS (flutter/engine#36685)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix flutter/flutter#113688
Test result
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.