This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Eliminate duplicated code when dealing with pointer data #36822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| memcpy(&data_[i * sizeof(PointerData)], &data, sizeof(PointerData)); | ||
| } | ||
|
|
||
| PointerData PointerDataPacket::GetPointerData(size_t i) const { | ||
| FML_DCHECK(i < GetLength()); |
There was a problem hiding this comment.
DCHECK only runs in debug mode. if the goal of this PR is to add bounds checking to make it safe, you need to always perform the bounds check
There was a problem hiding this comment.
I added DCHECK because originally there is no check at all and I dare not change semantics of the code (e.g. if no check because previous dev deliberately do so to avoid being too slow?). If you like, I will change to CHECK
dnfield
approved these changes
Oct 27, 2022
dnfield
changed the title
memcpy and duplicated code when dealing with pointer data
dnfield
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 36822, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
|
auto label is removed for flutter/engine, pr: 36822, due to Validations Fail. |
|
@dnfield Sure. Btw if you guys think the cost paid by CHECK is ok, I will change DCHECK to CHECK (pretty easy to change) |
|
CHECK will cause a crash at runtime. DCHECK is probably fine here to make tests fail. |
chinmaygarde
approved these changes
Nov 10, 2022
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 10, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 10, 2022
…115118) * 4f86f229d Update FlutterView.java (flutter/engine#37312) * 80e31edb2 Adding release_build:true to Mac builds. (flutter/engine#37478) * 2f5b7ac34 Eliminate duplicated code when dealing with pointer data (flutter/engine#36822) * f831382b7 Install CIPD ninja using DEPS (flutter/engine#37375) * 4cb9c1e00 mouse-input-view nit and add mouse-input-test to integration test script (flutter/engine#37441)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
* add methods * add empty test * add unit test * Update licenses_flutter * add const * size -> get length * add boundary checks * add tests * remove death test since it says "Death tests use fork(), which is unsafe particularly in a threaded context."
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115118) * 4f86f229d Update FlutterView.java (flutter/engine#37312) * 80e31edb2 Adding release_build:true to Mac builds. (flutter/engine#37478) * 2f5b7ac34 Eliminate duplicated code when dealing with pointer data (flutter/engine#36822) * f831382b7 Install CIPD ninja using DEPS (flutter/engine#37375) * 4cb9c1e00 mouse-input-view nit and add mouse-input-test to integration test script (flutter/engine#37441)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115118) * 4f86f229d Update FlutterView.java (flutter/engine#37312) * 80e31edb2 Adding release_build:true to Mac builds. (flutter/engine#37478) * 2f5b7ac34 Eliminate duplicated code when dealing with pointer data (flutter/engine#36822) * f831382b7 Install CIPD ninja using DEPS (flutter/engine#37375) * 4cb9c1e00 mouse-input-view nit and add mouse-input-test to integration test script (flutter/engine#37441)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope the PR is self-explanatory :) If needed I can explain it.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.