This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Autoresize playground imgui windows #37033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Oct 26, 2022
|
Isn't there a docking variant of ImGUI? We could use that to make these control layouts more consistent across more window sizes. Totally low priority though. |
chinmaygarde
approved these changes
Oct 26, 2022
|
Yeah, when I first landed ImGui I tried to use the docking branch, but unfortunately it required a later version of GLFW at the time, and for some reason I was unable to update GLFW. It's probably about time I give it another try. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets a default window position for all playgrounds. Gets rid of a silly hack to size an ImGui window that I did many moons ago and ended up getting copied dozens of times.
ImGui does a pretty good job with the autoresizing calculation, so somewhere along the line I started to have the windows size themselves.