This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Move gaussian functions into the shader library #37037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Oct 26, 2022
|
|
||
| #include <impeller/constants.glsl> | ||
|
|
||
| float IPGaussian(float x, float sigma) { |
There was a problem hiding this comment.
What's the meaning of the IP prefix?
There was a problem hiding this comment.
It's the C style namespacing of shader library functions.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the uniform refs from the gaussian functions and toss them into the shader lib.
In prep for rrect approximation improvements. Here's a sneak peak (the circles on the right are falling back to the regular gaussian blur for some reason, which currently looks sloppy with a high kernel size):