This repository was archived by the owner on Feb 25, 2025. It is now read-only.
reland "Migrate darwin common "framework_shared" target to ARC #37049" #37219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 1, 2022 09:31
jmagman
approved these changes
Nov 1, 2022
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 2, 2022
cyanglaz
pushed a commit
that referenced
this pull request
Nov 4, 2022
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Nov 9, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" This reverts commit cf22fc2.
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Nov 14, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" This reverts commit cf22fc2. remove copy format
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
…flutter#37049" (flutter#37219)" (flutter#37320) This reverts commit edb0492.
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Nov 23, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" This reverts commit cf22fc2.
8 tasks
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Nov 29, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" This reverts commit cf22fc2.
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Dec 13, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" This reverts commit cf22fc2.
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Dec 16, 2022
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" (flutter#37883) This reverts commit cf22fc2.
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
…et to ARC flutter#37049" (flutter#37219)" (flutter#37320)" (flutter#37883) This reverts commit cf22fc2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relands #37049
The original PR wrongly added weak modifies to the codec object that needs to be strongly captured by the block. See https://github.com/flutter/engine/pull/37049/files#r1010821732
The changes in this PR beyond 37049 including:
2, New unit tests have been added in this PR to ensure the bug is caught in engine.
part of flutter/flutter#112232
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.