Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix Pixel Ratio in Flatland Platform View #37268

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Fix Pixel Ratio in Flatland Platform View #37268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb7b14d
fix pixel ratio
cfontas Nov 3, 2022
6707530
Merge branch 'flutter:main' into DPR_Update
cfontas Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shell/platform/fuchsia/flutter/flatland_platform_view.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,14 @@ void FlatlandPlatformView::OnGetLayout(
view_logical_size_ = {static_cast<float>(info.logical_size().width),
static_cast<float>(info.logical_size().height)};

float pixel_ratio = 1.0f;
if (info.has_device_pixel_ratio()) {
// Flatland returns a Vec2 for DPR but both values should be identical.
FML_DCHECK(info.device_pixel_ratio().x == info.device_pixel_ratio().y);
view_pixel_ratio_ = info.device_pixel_ratio().x;
pixel_ratio = *view_pixel_ratio_;
}

float pixel_ratio = view_pixel_ratio_ ? *view_pixel_ratio_ : 1.0f;

SetViewportMetrics({
pixel_ratio, // device_pixel_ratio
std::round(view_logical_size_.value()[0] *
Expand Down