Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] validate that SkSL has no user supplied inputs #37293

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

jonahwilliams
Copy link
Member

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 3, 2022
@auto-submit auto-submit bot merged commit 2c9a6d6 into flutter:main Nov 3, 2022
@jonahwilliams jonahwilliams deleted the check_inputs branch November 3, 2022 20:51
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 4, 2022
…114648)

* 2c9a6d668 [Impeller] validate that SkSL has no user supplied inputs (flutter/engine#37293)

* ed31c3d76 Move the two remaining engine v2 builds to prod. (flutter/engine#37274)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
)

* [Impeller] validate that SkSL has no user supplied inputs

* ++
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#114648)

* 2c9a6d668 [Impeller] validate that SkSL has no user supplied inputs (flutter/engine#37293)

* ed31c3d76 Move the two remaining engine v2 builds to prod. (flutter/engine#37274)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller needs tests
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Adding variable with in storage qualifier crashes impellerc during shader hot reload
3 participants