This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update engine v2 builds to remove gclient_custom_var support #37494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The support for per-build custom gclient variable overrides is removed from the build recipes, so the unused fields in the build configuration json are removed here. This completes the change made in flutter#37351 Bug: flutter/flutter#114656
godofredoc
reviewed
Nov 12, 2022
| @@ -18,9 +18,6 @@ | |||
| "device_type=none", | |||
| "os=Linux" | |||
| ], | |||
| "gclient_custom_vars": { | |||
There was a problem hiding this comment.
Thank you for the change! would it be possible to rename to gclient_variables instead?
|
Ping @whesse on @godofredoc s query. |
|
Closing as stale. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for per-build custom gclient variable overrides is removed from the build recipes, so the unused fields in the build configuration json are removed here.
This completes the change made in #37351
Bug: flutter/flutter#114656