This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Do not call Dart_NotifyIdle when in Dart_PerformanceMode_Latency #37499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure that smoother animations take precedence over idle notifications that trigger GC work.
iskakaushik
force-pushed
the
idle-notifier
branch
from
3c2fb4d to
f8fb1ab
Compare
dnfield
reviewed
Nov 11, 2022
| @@ -219,6 +219,12 @@ bool RuntimeController::NotifyIdle(fml::TimePoint deadline) { | |||
|
|
|||
| tonic::DartState::Scope scope(root_isolate); | |||
|
|
|||
| Dart_PerformanceMode performance_mode = | |||
There was a problem hiding this comment.
It might be better if we could cut this off in the animator instead, and avoid even scheduling the delayed task during this time.
However, I'm also looking into refactoring that logic a bit right now anyway, since I think it's doing duplicate work in some cases.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 11, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 11, 2022
…115134) * e48e72ddd Roll buildroot to f63462f. (flutter/engine#37497) * d83132b54 Do not call Dart_NotifyIdle when in Dart_PerformanceMode_Latency (flutter/engine#37499) * cb78576e5 Roll Skia from b50a2f714837 to b50f741ef341 (2 revisions) (flutter/engine#37508)
|
@iskakaushik Are there any benchmarks on CI that we should keep an eye on for changes related to this PR? |
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115134) * e48e72ddd Roll buildroot to f63462f. (flutter/engine#37497) * d83132b54 Do not call Dart_NotifyIdle when in Dart_PerformanceMode_Latency (flutter/engine#37499) * cb78576e5 Roll Skia from b50a2f714837 to b50f741ef341 (2 revisions) (flutter/engine#37508)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115134) * e48e72ddd Roll buildroot to f63462f. (flutter/engine#37497) * d83132b54 Do not call Dart_NotifyIdle when in Dart_PerformanceMode_Latency (flutter/engine#37499) * cb78576e5 Roll Skia from b50a2f714837 to b50f741ef341 (2 revisions) (flutter/engine#37508)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure that smoother animations take precedence over idle notifications that trigger GC work.