Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[canvaskit] Fix Surface test #37636

Merged

Conversation

harryterkelsen
Copy link
Contributor

This fixes the Path tests that regressed as a result of test results not being reported properly.

Partially addresses flutter/flutter#115327

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Nov 15, 2022
@harryterkelsen harryterkelsen added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Nov 16, 2022
@harryterkelsen harryterkelsen merged commit 850c4ad into flutter:main Dec 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 3, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 3, 2022
…116447)

* bebc12fd0 Roll Skia from 28c1bbab82b8 to 6fdf7181e374 (16 revisions) (flutter/engine#38046)

* 2c1e5efae [Impeller] add --enable-impeller-3d flag to support scene experimentation (flutter/engine#37990)

* 8e11659a8 [canvaskit] Fix Shader program tests (flutter/engine#37644)

* 850c4ad68 [canvaskit] Fix Surface test (flutter/engine#37636)

* f7df812d2 save (flutter/engine#37107)
mit-mit pushed a commit to mit-mit/flutter that referenced this pull request Dec 6, 2022
…lutter#116447)

* bebc12fd0 Roll Skia from 28c1bbab82b8 to 6fdf7181e374 (16 revisions) (flutter/engine#38046)

* 2c1e5efae [Impeller] add --enable-impeller-3d flag to support scene experimentation (flutter/engine#37990)

* 8e11659a8 [canvaskit] Fix Shader program tests (flutter/engine#37644)

* 850c4ad68 [canvaskit] Fix Surface test (flutter/engine#37636)

* f7df812d2 save (flutter/engine#37107)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#116447)

* bebc12fd0 Roll Skia from 28c1bbab82b8 to 6fdf7181e374 (16 revisions) (flutter/engine#38046)

* 2c1e5efae [Impeller] add --enable-impeller-3d flag to support scene experimentation (flutter/engine#37990)

* 8e11659a8 [canvaskit] Fix Shader program tests (flutter/engine#37644)

* 850c4ad68 [canvaskit] Fix Surface test (flutter/engine#37636)

* f7df812d2 save (flutter/engine#37107)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#116447)

* bebc12fd0 Roll Skia from 28c1bbab82b8 to 6fdf7181e374 (16 revisions) (flutter/engine#38046)

* 2c1e5efae [Impeller] add --enable-impeller-3d flag to support scene experimentation (flutter/engine#37990)

* 8e11659a8 [canvaskit] Fix Shader program tests (flutter/engine#37644)

* 850c4ad68 [canvaskit] Fix Surface test (flutter/engine#37636)

* f7df812d2 save (flutter/engine#37107)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants