Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Update text editing test skips #37642

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

harryterkelsen
Copy link
Contributor

This fixes the text editing tests that regressed as a result of test results not being reported properly.

Partially addresses flutter/flutter#115327

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@harryterkelsen harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 15, 2022
@auto-submit auto-submit bot merged commit eedb93e into flutter:main Nov 15, 2022
harryterkelsen pushed a commit that referenced this pull request Nov 16, 2022
harryterkelsen pushed a commit that referenced this pull request Nov 16, 2022
harryterkelsen pushed a commit that referenced this pull request Nov 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 16, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 16, 2022
…115406)

* 6563c5843 Remove felt snapshotting behavior. (flutter/engine#37639)

* c6e556489 Update language version in flutter_frontend_server/test/fixtures (flutter/engine#37643)

* eedb93eb7 Update text editing tests (flutter/engine#37642)

* a1dd33540 colorFilter as imageFilter for web (flutter/engine#37522)

* b74c2c57a Remove usage of deprecated Fuchsia event source (flutter/engine#37641)

* e56ed93fa Revert "Update text editing tests (#37642)" (flutter/engine#37653)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#115406)

* 6563c5843 Remove felt snapshotting behavior. (flutter/engine#37639)

* c6e556489 Update language version in flutter_frontend_server/test/fixtures (flutter/engine#37643)

* eedb93eb7 Update text editing tests (flutter/engine#37642)

* a1dd33540 colorFilter as imageFilter for web (flutter/engine#37522)

* b74c2c57a Remove usage of deprecated Fuchsia event source (flutter/engine#37641)

* e56ed93fa Revert "Update text editing tests (flutter#37642)" (flutter/engine#37653)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#115406)

* 6563c5843 Remove felt snapshotting behavior. (flutter/engine#37639)

* c6e556489 Update language version in flutter_frontend_server/test/fixtures (flutter/engine#37643)

* eedb93eb7 Update text editing tests (flutter/engine#37642)

* a1dd33540 colorFilter as imageFilter for web (flutter/engine#37522)

* b74c2c57a Remove usage of deprecated Fuchsia event source (flutter/engine#37641)

* e56ed93fa Revert "Update text editing tests (flutter#37642)" (flutter/engine#37653)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants