This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Make the engine own the PlatformHandler
#37855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
Nov 23, 2022
| const FlutterWindowsView* view = engine_->view(); | ||
| if (view == nullptr) { | ||
| result->Error(kClipboardError, | ||
| "Clipboard is not available in Windows headless mode"); |
There was a problem hiding this comment.
This message mirrors the GLFW message:
engine/shell/platform/glfw/platform_handler.cc
Lines 47 to 51 in f75287a
Please let me know if you have suggestions though!
yaakovschectman
approved these changes
Nov 23, 2022
|
This seems good to go. Can we land it? |
loic-sharma
force-pushed
the
windows_platform_handler
branch
from
f427b3a to
51e4e32
Compare
loic-sharma
added
the
autosubmit
|
Yup. Apologies for the delay, I was out last week! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 5, 2022
…116547) * 3f997f01c Roll Skia from 1a8a0e1113da to e9c0d4b83ca4 (2 revisions) (flutter/engine#38077) * e2b1919a7 [Windows] Make the engine own PlatformHandler (flutter/engine#37855)
mit-mit
pushed a commit
to mit-mit/flutter
that referenced
this pull request
Dec 6, 2022
…lutter#116547) * 3f997f01c Roll Skia from 1a8a0e1113da to e9c0d4b83ca4 (2 revisions) (flutter/engine#38077) * e2b1919a7 [Windows] Make the engine own PlatformHandler (flutter/engine#37855)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#116547) * 3f997f01c Roll Skia from 1a8a0e1113da to e9c0d4b83ca4 (2 revisions) (flutter/engine#38077) * e2b1919a7 [Windows] Make the engine own PlatformHandler (flutter/engine#37855)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#116547) * 3f997f01c Roll Skia from 1a8a0e1113da to e9c0d4b83ca4 (2 revisions) (flutter/engine#38077) * e2b1919a7 [Windows] Make the engine own PlatformHandler (flutter/engine#37855)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows
PlatformHandleris a singleton, however, it is owned by the view. This makes thePlatformHandlerowned by the engine to prepare for a multi-view world.Part of flutter/flutter#115611
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.