Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Implement 'ui.decodeImageFromPixels' #37866

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Nov 23, 2022

fix flutter/flutter#115907

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ColdPaleLight ColdPaleLight self-assigned this Nov 23, 2022
@ColdPaleLight ColdPaleLight requested review from chinmaygarde and bdero and removed request for chinmaygarde November 23, 2022 08:34
@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 23, 2022
@auto-submit auto-submit bot merged commit a0f0b99 into flutter:main Nov 23, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 24, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 24, 2022
…115957)

* a0f0b99a3 [Impeller] Implement 'ui.decodeImageFromPixels' (flutter/engine#37866)

* 9b2895724 Roll Skia from 805fd7443f42 to 665ae344c8ec (1 revision) (flutter/engine#37881)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#115957)

* a0f0b99a3 [Impeller] Implement 'ui.decodeImageFromPixels' (flutter/engine#37866)

* 9b2895724 Roll Skia from 805fd7443f42 to 665ae344c8ec (1 revision) (flutter/engine#37881)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#115957)

* a0f0b99a3 [Impeller] Implement 'ui.decodeImageFromPixels' (flutter/engine#37866)

* 9b2895724 Roll Skia from 805fd7443f42 to 665ae344c8ec (1 revision) (flutter/engine#37881)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller needs tests
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Impeller] Implement 'ui.decodeImageFromPixels'
2 participants