Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Pack 👏 the 👏 atlas 👏 #38024

Merged
merged 3 commits into from
Dec 2, 2022
Merged

[Impeller] Pack 👏 the 👏 atlas 👏 #38024

merged 3 commits into from
Dec 2, 2022

Conversation

bdero
Copy link
Member

@bdero bdero commented Dec 2, 2022 •
edited
Loading

...with individual glyph bounds.

Before:
1024 x 1024
Screen Shot 2022-12-01 at 7 24 08 PM

After:
512 x 512
Screen Shot 2022-12-01 at 7 21 06 PM

@bdero bdero self-assigned this Dec 2, 2022
@jonahwilliams
Copy link
Member

man I wish Github had gifs like discord and gchat so I could post a funny meme on this

jonahwilliams
jonahwilliams approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero bdero merged commit b5242cc into flutter:main Dec 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 2, 2022
@engine-flutter-autoroll
b5242ccfb [Impeller] Pack 👏 the 👏 atlas 👏 (flutter/engine#38024)
a2e5812
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 2, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 4c72d5c82152 to 8e0747cc306f (7 revisions) (#…
5c97543 
…116426)

* 6c4dd8555 Roll Skia from b273c4c744be to 355045d108f0 (10 revisions) (flutter/engine#38021)

* 87e74118d Roll Skia from 355045d108f0 to e4273a995436 (1 revision) (flutter/engine#38023)

* b5242ccfb [Impeller] Pack 👏 the 👏 atlas 👏 (flutter/engine#38024)

* 1f94931c0 Roll Skia from e4273a995436 to c6a481bef3fb (1 revision) (flutter/engine#38025)

* fbe067645 Roll Skia from c6a481bef3fb to 5e687e4aced6 (1 revision) (flutter/engine#38027)

* df7ea39a7 Roll Skia from 5e687e4aced6 to c432cb7480b5 (1 revision) (flutter/engine#38029)

* 8e0747cc3 Roll Fuchsia Mac SDK from hODX8Qi_7J5kwKp4S... to aHgLxcRDjOQNKL7zH... (flutter/engine#38031)
@zanderso
Copy link
Member

zanderso commented Dec 2, 2022

Pretty good speedup on Android. Unfortunately we don't have the benchmark on iOS, but I assume it would be a good improvement there, too.

https://flutter-flutter-perf.skia.org/e/?begin=1669946990&end=1670017066&keys=Xbe52a0bd5622e359e13dd9b924b88ea6&selected=commit%3D32354%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DMoto_G__4_%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253D90th_percentile_frame_rasterizer_time_millis%252Ctest%253Dlist_text_layout_impeller_perf__e2e_summary%252C&xbaroffset=32354

@bdero
Copy link
Member Author

bdero commented Dec 3, 2022

I expect this to be mostly a GPU improvement for cases like:

  • Large text (like in Wondrous), which tends to have extreme glyph spacing.
  • Any screen with high text density. Most fonts seem to have quite a large min/max X boundary range (like 4-6x the width of most glyphs), making the step that samples from the atlas, well, 4-6x more fragment load on the GPU -- epic tons of overdraw rendering nothing.

zanderso pushed a commit to zanderso/engine that referenced this pull request Dec 5, 2022
@bdero @zanderso
[Impeller] Pack 👏 the 👏 atlas 👏 (flutter#38024)
54abb31
@zanderso zanderso mentioned this pull request Dec 5, 2022
Merged
itsjustkevin pushed a commit that referenced this pull request Dec 5, 2022
@zanderso @bdero
[Impeller] Pack 👏 the 👏 atlas 👏 (#38024) (#38072)
10b5316 
Co-authored-by: Brandon DeRosier <[email protected]>
mit-mit pushed a commit to mit-mit/flutter that referenced this pull request Dec 6, 2022
@engine-flutter-autoroll @mit-mit
Roll Flutter Engine from 4c72d5c82152 to 8e0747cc306f (7 revisions) (f…
49d45f0 
…lutter#116426)

* 6c4dd8555 Roll Skia from b273c4c744be to 355045d108f0 (10 revisions) (flutter/engine#38021)

* 87e74118d Roll Skia from 355045d108f0 to e4273a995436 (1 revision) (flutter/engine#38023)

* b5242ccfb [Impeller] Pack 👏 the 👏 atlas 👏 (flutter/engine#38024)

* 1f94931c0 Roll Skia from e4273a995436 to c6a481bef3fb (1 revision) (flutter/engine#38025)

* fbe067645 Roll Skia from c6a481bef3fb to 5e687e4aced6 (1 revision) (flutter/engine#38027)

* df7ea39a7 Roll Skia from 5e687e4aced6 to c432cb7480b5 (1 revision) (flutter/engine#38029)

* 8e0747cc3 Roll Fuchsia Mac SDK from hODX8Qi_7J5kwKp4S... to aHgLxcRDjOQNKL7zH... (flutter/engine#38031)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Flutter Engine from 4c72d5c82152 to 8e0747cc306f (7 revisions) (f…
caf8439 
…lutter#116426)

* 6c4dd8555 Roll Skia from b273c4c744be to 355045d108f0 (10 revisions) (flutter/engine#38021)

* 87e74118d Roll Skia from 355045d108f0 to e4273a995436 (1 revision) (flutter/engine#38023)

* b5242ccfb [Impeller] Pack 👏 the 👏 atlas 👏 (flutter/engine#38024)

* 1f94931c0 Roll Skia from e4273a995436 to c6a481bef3fb (1 revision) (flutter/engine#38025)

* fbe067645 Roll Skia from c6a481bef3fb to 5e687e4aced6 (1 revision) (flutter/engine#38027)

* df7ea39a7 Roll Skia from 5e687e4aced6 to c432cb7480b5 (1 revision) (flutter/engine#38029)

* 8e0747cc3 Roll Fuchsia Mac SDK from hODX8Qi_7J5kwKp4S... to aHgLxcRDjOQNKL7zH... (flutter/engine#38031)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 4c72d5c82152 to 8e0747cc306f (7 revisions) (f…
e909a67 
…lutter#116426)

* 6c4dd8555 Roll Skia from b273c4c744be to 355045d108f0 (10 revisions) (flutter/engine#38021)

* 87e74118d Roll Skia from 355045d108f0 to e4273a995436 (1 revision) (flutter/engine#38023)

* b5242ccfb [Impeller] Pack 👏 the 👏 atlas 👏 (flutter/engine#38024)

* 1f94931c0 Roll Skia from e4273a995436 to c6a481bef3fb (1 revision) (flutter/engine#38025)

* fbe067645 Roll Skia from c6a481bef3fb to 5e687e4aced6 (1 revision) (flutter/engine#38027)

* df7ea39a7 Roll Skia from 5e687e4aced6 to c432cb7480b5 (1 revision) (flutter/engine#38029)

* 8e0747cc3 Roll Fuchsia Mac SDK from hODX8Qi_7J5kwKp4S... to aHgLxcRDjOQNKL7zH... (flutter/engine#38031)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@zanderso zanderso Awaiting requested review from zanderso

Assignees

@bdero bdero

Labels
e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdero @jonahwilliams @zanderso