Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Check for renderer-specific versions of the tests first. #38088

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Check for renderer-specific versions of the tests first. #38088

merged 2 commits into from
Dec 6, 2022

Conversation

eyebrowsoffire
Copy link
Contributor

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Dec 6, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

yjbanov
yjbanov approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skia-gold
Copy link

Gold has detected about 73 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/38088

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2022
@auto-submit auto-submit bot merged commit 86d7cbf into flutter:main Dec 6, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2022
@engine-flutter-autoroll
86d7cbf09 Check for renderer-specific versions of the tests first. (f…
48ff1ac 
…lutter/engine#38088)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 6, 2022
@engine-flutter-autoroll
Roll Flutter Engine from e6e6a02106c6 to 86d7cbf09e09 (2 revisions) (#…
e2fb672 
…116601)

* 75b7f317d Roll Fuchsia Mac SDK from 8p38Xk7Z7OLI7OA7R... to crEcyXdyZ686cAqMV... (flutter/engine#38100)

* 86d7cbf09 Check for renderer-specific versions of the tests first. (flutter/engine#38088)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Flutter Engine from e6e6a02106c6 to 86d7cbf09e09 (2 revisions) (f…
3a402b9 
…lutter#116601)

* 75b7f317d Roll Fuchsia Mac SDK from 8p38Xk7Z7OLI7OA7R... to crEcyXdyZ686cAqMV... (flutter/engine#38100)

* 86d7cbf09 Check for renderer-specific versions of the tests first. (flutter/engine#38088)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from e6e6a02106c6 to 86d7cbf09e09 (2 revisions) (f…
8614ea7 
…lutter#116601)

* 75b7f317d Roll Fuchsia Mac SDK from 8p38Xk7Z7OLI7OA7R... to crEcyXdyZ686cAqMV... (flutter/engine#38100)

* 86d7cbf09 Check for renderer-specific versions of the tests first. (flutter/engine#38088)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

felt test runs stale code despite correctly compiling the source
3 participants
@eyebrowsoffire @skia-gold @yjbanov