This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Speculatively attempt to fix Metal PSO construction errors on host targets. #38229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on host targets. Fixes flutter/flutter#114872 (speculatively) Following up in flutter/flutter#116919.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
approved these changes
Dec 12, 2022
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2022
…ion errors on host targets. (flutter/engine#38229)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2022
…ion errors on host targets. (flutter/engine#38229)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 13, 2022
…116939) * b97d3545f [Impeller] Speculatively attempt to fix Metal PSO construction errors on host targets. (flutter/engine#38229) * 99f3d1931 Web trackpad pan (flutter/engine#36346) * e144f81e9 [impeller] Fix typo in compiller help (flutter/engine#38214)
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Dec 16, 2022
… on host targets. (flutter#38229) Fixes flutter/flutter#114872 (speculatively) Following up in flutter/flutter#116919.
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
… on host targets. (flutter#38229) Fixes flutter/flutter#114872 (speculatively) Following up in flutter/flutter#116919.
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#116939) * b97d3545f [Impeller] Speculatively attempt to fix Metal PSO construction errors on host targets. (flutter/engine#38229) * 99f3d1931 Web trackpad pan (flutter/engine#36346) * e144f81e9 [impeller] Fix typo in compiller help (flutter/engine#38214)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the PSO construction not use a worker since the theory is that device teardown in the test harness is tickling a race condition in the Metal framework.
Fixes flutter/flutter#114872 (speculatively).
Following up in flutter/flutter#116919.