-
Notifications
You must be signed in to change notification settings - Fork 6k
Remove DisplayList's dependency on SkAutoTMalloc #38359
Remove DisplayList's dependency on SkAutoTMalloc #38359
Conversation
SkAutoTMalloc is not a public Skia API
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a code switch from one mechanism to another equivalent mechanism so there is no way to test the change itself. Its correctness will be tested by existing unit and framework tests... |
…117246) * 1fe1ec414 Clarify semantics action dispatch id parameter (flutter/engine#38356) * 985f4ac51 Ensure licenses excluded file list has newline at EOF (flutter/engine#38354) * 4097c333f Update documentation to use `--local-web-sdk` flags. (flutter/engine#38328) * 60cf34e2a Remove DisplayList's dependency on SkAutoTMalloc (flutter/engine#38359)
SkAutoTMalloc is not a public Skia API
…lutter#117246) * 1fe1ec414 Clarify semantics action dispatch id parameter (flutter/engine#38356) * 985f4ac51 Ensure licenses excluded file list has newline at EOF (flutter/engine#38354) * 4097c333f Update documentation to use `--local-web-sdk` flags. (flutter/engine#38328) * 60cf34e2a Remove DisplayList's dependency on SkAutoTMalloc (flutter/engine#38359)
SkAutoTMalloc is not a public Skia API