This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove use of SkTAddOffset and sk_careful_memcpy #38977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jason-simmons
approved these changes
Jan 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2023
…118743) * 2722c548b Remove use of SkTAddOffset and sk_careful_memcpy (flutter/engine#38977) * 290636c1c Get unit tests working with dart2wasm (flutter/engine#38784)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#118743) * 2722c548b Remove use of SkTAddOffset and sk_careful_memcpy (flutter/engine#38977) * 290636c1c Get unit tests working with dart2wasm (flutter/engine#38784)
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are both private Skia APIs and should not be directly used.
See skbug.com/13983 as the tracking bug for tightening down private APIs.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.