This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Handle proto deps that were added to the Dart SDK #39098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is my planned process for integrating these changes:
Plese let me know if this sounds good. |
|
To avoid breaking the Engine tree, the buildroot roll, this engine PR, and a manual Dart roll should be combined into a single PR. |
derekxu16
force-pushed
the
handle-dart-proto-deps
branch
9 times, most recently
from
a4c8b86 to
854a50d
Compare
zanderso
reviewed
Jan 27, 2023
derekxu16
force-pushed
the
handle-dart-proto-deps
branch
from
854a50d to
d812944
Compare
derekxu16
force-pushed
the
handle-dart-proto-deps
branch
from
d812944 to
4316fef
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 27, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 27, 2023
…119369) * ab1eda7c7 Handle proto deps that were added to the Dart SDK (flutter/engine#39098) * 70f96af0a [impellerc] remove coffset usage (flutter/engine#39199) * 4bab18407 [impellerc] remove remaining remap sampler support (flutter/engine#39198) * a1e657a1e Move Linux Fuchsia FEMU to bringup due to flakes (flutter/engine#39202) * 8567d9699 [Impeller] support overlapping stops with SSBO gradients. (flutter/engine#39174)
zanderso
reviewed
Jan 30, 2023
| 'src/third_party/protobuf': | ||
| Var('fuchsia_git') + '/third_party/protobuf' + '@' + Var('dart_libprotobuf_rev'), | ||
|
|
||
| 'src/build/secondary/third_party/protobuf': |
There was a problem hiding this comment.
@derekxu16 This path should be added to the .gitignore at https://github.com/flutter/buildroot/blob/master/.gitignore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dart SDK will be adding third-party dependencies that it needs to serialize protos in https://dart-review.googlesource.com/c/sdk/+/278200.