Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Add and reorder FAQ entries. #39106

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

chinmaygarde
Copy link
Member

No description provided.

Co-authored-by: Loïc Sharma <[email protected]>
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent improvement, but I am still concerned that this page is overwhelming for the blog post's intended audience. I would still recommend having a dedicated docs page for the Impeller iOS preview.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 24, 2023

auto label is removed for flutter/engine, pr: 39106, due to - The status or check suite Linux Fuchsia FEMU has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2023
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2023
@auto-submit auto-submit bot merged commit d98926c into flutter:main Jan 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 25, 2023
…119090)

* acb561092 [web] Remove dependency on 'profiling' subfolder of canvaskit. (flutter/engine#38169)

* d98926c32 [Impeller] Add and reorder FAQ entries. (flutter/engine#39106)
@chinmaygarde chinmaygarde deleted the updatefaq branch January 25, 2023 02:16
ricardoamador pushed a commit to ricardoamador/engine that referenced this pull request Jan 25, 2023
* [Impeller] Add and reorder FAQ entries.

* Update impeller/docs/faq.md

Co-authored-by: Loïc Sharma <[email protected]>

Co-authored-by: Loïc Sharma <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants