This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Use 'ninja' instead of 'ninja.exe' #39326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbracken @godofredoc Please let me know if there are other folks I should add as reviewers. |
yaakovschectman
approved these changes
Feb 2, 2023
zanderso
approved these changes
Feb 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2023
…119830) * e64f3264c Add missing file to artifacts.zip and win platform. (flutter/engine#39310) * a19cf360a Roll Skia from 934ef0660509 to c3c5c6f61421 (1 revision) (flutter/engine#39332) * 76dc4f989 Roll Skia from c3c5c6f61421 to 532c04c00ad7 (1 revision) (flutter/engine#39333) * 8a74e633e Roll Dart SDK from 99014717b633 to 11d97405a447 (3 revisions) (flutter/engine#39337) * 67662080e Roll Fuchsia Mac SDK from j5rQsxkO2VJrX55Yj... to rqjJA8z_K0gdGcsvA... (flutter/engine#39338) * 388890a98 [Windows] Use 'ninja' instead of 'ninja.exe' (flutter/engine#39326)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine's Visual Studio integration is currently broken. See: https://groups.google.com/a/chromium.org/g/chromium-dev/c/027jM6DLkIk
Note that the Visual Studio integration won't be fixed until depot_tools#4215121 lands.
Part of: flutter/flutter#119760
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.