Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Don't ceil subpass texture sizes #39336

Merged
merged 2 commits into from
Feb 2, 2023
Merged

[Impeller] Don't ceil subpass texture sizes #39336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
763799d
[Impeller] Don't ceil subpass texture sizes
bdero Feb 2, 2023
5161d56
Better conditional
bdero Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions impeller/entity/entity_pass.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,14 +322,10 @@ EntityPass::EntityResult EntityPass::GetEntityForElement(
return EntityPass::EntityResult::Skip();
}

RenderTarget subpass_target;
if (subpass->reads_from_pass_texture_ > 0) {
subpass_target = CreateRenderTarget(
renderer, ISize::Ceil(subpass_coverage->size), true);
} else {
subpass_target = CreateRenderTarget(
renderer, ISize::Ceil(subpass_coverage->size), false);
}
auto subpass_target =
CreateRenderTarget(renderer, //
ISize(subpass_coverage->size), //
subpass->reads_from_pass_texture_ > 0);

auto subpass_texture = subpass_target.GetRenderTargetTexture();

Expand Down