This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Fix render transform is not correct. #39617
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Feb 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2023
…120850) * b7ec9ce18 [macOS] Improve TextInputPlugin test readability (flutter/engine#39664) * a6e8fb134 Roll Dart SDK from a594e34e85b6 to ce9397c5fc8f (1 revision) (flutter/engine#39667) * 3fc40ca5b ++ (flutter/engine#39617)
@luckysmg I think we still have this issue. Look at “Reply to Leo”. That is a flutter placeholder. IMG_7805.MOV |
Emm i didn't see any incorrect😳 |
My bad, I double checked it and was trick of the eye 👍 |
Saw this yesterday, not sure if it is unrelated |
I think that maybe a issue of filter (But I m not very familiar with how filter works at present o(╥﹏╥)o ). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
We should cover
zfar = +infinity
andznear = -infinity
.So the
zScale
inMakeOrthographic
should be1 / (infinity - (-infinity)) = 1 / infinity = 0
For example in linked issue
Dart sample code
For test
CanDrawCorrectlyWithRotatedTransformation
Before
Before.mp4
After
After.mp4
Pre-launch Checklist
///
).