This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Set textfield autofill type #39632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
reviewed
Feb 14, 2023
shell/platform/darwin/macos/framework/Source/FlutterTextInputPlugin.mm
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Feb 14, 2023
shell/platform/darwin/macos/framework/Source/FlutterTextInputPluginTest.mm
Show resolved
Hide resolved
loic-sharma
approved these changes
Feb 14, 2023
cbracken
force-pushed
the
autofill-content-type
branch
from
3a8eb2e to
7d60ee3
Compare
yaakovschectman
approved these changes
Feb 14, 2023
macOS supports three autofill types: username, password, and oneTimeCode. Apply these content types when the equivalent Flutter autofill hints are set. Note that enabling autocomplete of username and password in applications will still require setting the "Autofill Credential Provider" and "Associated Domains" entitlements, and for the FlutterTextInputPlugin to be updated to use an NSSecureTextInput input type. Issue: flutter/flutter#120252
cbracken
force-pushed
the
autofill-content-type
branch
from
7d60ee3 to
702ad9e
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 15, 2023
…120821) * b59787f40 Roll Skia from cd19d680b078 to 21627ff455d0 (2 revisions) (flutter/engine#39650) * 9af56b3ee [macOS] Set textfield autofill type (flutter/engine#39632) * a8b3d1af5 Added wide gamut colors to offscreen buffers (flutter/engine#39482)
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Feb 16, 2023
This just extracts arguments to the TextInputClient.setClient async method call into an NSDictionary local to reduce the deep indentation of the formatted code. While the bulk of these calls are identical and could be extracted to a utility function, or a class extension method like `handleDefaultSetClientCall`, the point of these tests is to exercise FlutterTextInputPlugin, and the message protocol over the channel are precisely what's being tested, so it makes sense to keep these explicit. Followup patch to flutter#39632. Issue: flutter/flutter#120252
8 tasks
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Feb 16, 2023
This just extracts arguments to the TextInputClient.setClient async method call into an NSDictionary local to reduce the deep indentation of the formatted code. While the bulk of these calls are identical and could be extracted to a utility function, or a class extension method like `handleDefaultSetClientCall`, the point of these tests is to exercise FlutterTextInputPlugin, and the message protocol over the channel are precisely what's being tested, so it makes sense to keep these explicit. Followup patch to flutter#39632. Issue: flutter/flutter#120252
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Feb 16, 2023
This just extracts arguments to the TextInputClient.setClient async method call into an NSDictionary local to reduce the deep indentation of the formatted code. While the bulk of these calls are identical and could be extracted to a utility function, or a class extension method like `handleDefaultSetClientCall`, the point of these tests is to exercise FlutterTextInputPlugin, and the message protocol over the channel are precisely what's being tested, so it makes sense to keep these explicit. Followup patch to flutter#39632. Issue: flutter/flutter#120252
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Feb 16, 2023
This just extracts arguments to the TextInputClient.setClient async method call into an NSDictionary local to reduce the deep indentation of the formatted code. While the bulk of these calls are identical and could be extracted to a utility function, or a class extension method like `handleDefaultSetClientCall`, the point of these tests is to exercise FlutterTextInputPlugin, and the message protocol over the channel are precisely what's being tested, so it makes sense to keep these explicit. Followup patch to flutter#39632. Issue: flutter/flutter#120252
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
This just extracts arguments to the TextInputClient.setClient async method call into an NSDictionary local to reduce the deep indentation of the formatted code. While the bulk of these calls are identical and could be extracted to a utility function, or a class extension method like `handleDefaultSetClientCall`, the point of these tests is to exercise FlutterTextInputPlugin, and the message protocol over the channel are precisely what's being tested, so it makes sense to keep these explicit. Followup patch to #39632. Issue: flutter/flutter#120252
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS supports three autofill types: username, password, and oneTimeCode. Apply these content types when the equivalent Flutter autofill hints are set.
Note that enabling autocomplete of username and password in applications will still require setting the "Autofill Credential Provider" and "Associated Domains" entitlements, and for the FlutterTextInputPlugin to be updated to use an NSSecureTextInput input type.
Issue: flutter/flutter#120252
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.