-
Notifications
You must be signed in to change notification settings - Fork 6k
Turned off wide gamut color pixel format for the simulator #39825
Turned off wide gamut color pixel format for the simulator #39825
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@gaaclarke did Apple document this somewhere? |
I found out just through experience. I didn't look it up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As of Xcode 14.1, the pixel format we use isn't supported by the simulator.
If you try to execute with that pixel format in the simulator the metal api validation will crash. Without validation you'll get a black screen or crash. I've tested Safari on the simulator and it didn't render wide gamut colors either, so I don't think it works for any pixel format although it does report it's displays gamut is not sRGB.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.