Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix imports for FlutterApplication #40100

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Fix imports for FlutterApplication #40100

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
534dba8
Fix imports for FlutterApplication
gspencergoog Mar 6, 2023
99e947e
Remove extra line
gspencergoog Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions shell/platform/darwin/macos/framework/Source/FlutterApplication.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
#import "flutter/shell/platform/darwin/macos/framework/Headers/FlutterApplication.h"
#import "flutter/shell/platform/darwin/macos/framework/Source/FlutterApplication_Internal.h"

#import "flutter/shell/platform/darwin/macos/framework/Headers/FlutterAppDelegate.h"
#import "flutter/shell/platform/darwin/macos/framework/Source/FlutterAppDelegate_Internal.h"
#import "flutter/shell/platform/darwin/macos/framework/Source/FlutterEngine_Internal.h"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the spare line here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, OK. I thought I should separate the C++ from the Objective C headers.

#include "flutter/shell/platform/embedder/embedder.h"
#import "shell/platform/darwin/macos/framework/Headers/FlutterAppDelegate.h"
#import "shell/platform/darwin/macos/framework/Source/FlutterAppDelegate_Internal.h"
#import "shell/platform/darwin/macos/framework/Source/FlutterEngine_Internal.h"

// An NSApplication subclass that implements overrides necessary for some
// Flutter features, like application lifecycle handling.
Expand Down