-
Notifications
You must be signed in to change notification settings - Fork 6k
Android: Made sure we get the initial route from the intent. #40148
Conversation
attn @math1man |
Oh I fixed this issue here but I did something different I think because I thought the cause was different: #40119. Does this fix it? There's a repro here flutter/flutter#121244 |
This LGTM. I think this is a more consistent and efficient fix than #40119 |
This fix was based off of the debugging that @math1man did. His analysis makes sense to me although @camsim99 will probably have a better sense than me about the different flows through this code. Assuming that this works, this fix seems preferable. @math1man made a good point that there are some temporal dependencies about when you an access the activity so making sure our scenario apps pass on ci will be important. It would be nice if he could test the fix in his app just to make sure. |
cc @reidbaker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
fixes b/271100292
Edit: Fixes flutter/flutter#121244.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.