Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Fix canvasKitVariant test #40833

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[web] Fix canvasKitVariant test #40833

merged 1 commit into from
Mar 31, 2023

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Mar 31, 2023

Right now we only check for v8BreakIterator and we don't check ImageDecoder support. So some tests need to be updated.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 31, 2023
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Mar 31, 2023
@auto-submit auto-submit bot merged commit a378da4 into flutter:main Mar 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request Apr 1, 2023
…sions) (#123924)

Manual roll requested by [email protected]

flutter/engine@b2855e0...a48eedb

2023-04-01 [email protected] Revert "[web] Move text
editing nodes outside of shadowDOM" (flutter/engine#40847)
2023-04-01 [email protected] Roll Skia from 4d1e9cabf0c8 to
9973ef180f1f (2 revisions) (flutter/engine#40843)
2023-04-01 [email protected] Roll Dart SDK from
6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter/engine#40842)
2023-04-01 [email protected] [Impeller] take advantage of native
decal sampling, blend cleanups (flutter/engine#40839)
2023-04-01 [email protected] Revert "[web] use callConstructor for
FinalizationRegistry due to bug… (flutter/engine#40841)
2023-04-01 [email protected] Revert "Add ui_web to
embedder.yaml so that the analyzer knows about it."
(flutter/engine#40840)
2023-04-01 [email protected] [Impeller] Migrate gaussian blur to
half precision. (flutter/engine#40800)
2023-03-31 [email protected] Roll Skia from 33f80c07a09c to
4d1e9cabf0c8 (3 revisions) (flutter/engine#40836)
2023-03-31 [email protected] [web] Move text
editing nodes outside of shadowDOM (flutter/engine#39688)
2023-03-31 [email protected] [web] Fix canvasKitVariant test
(flutter/engine#40833)
2023-03-31 [email protected] [web] use callConstructor for
FinalizationRegistry due to bug in dart2js (flutter/engine#40798)
2023-03-31 [email protected] Roll Fuchsia Mac SDK from
kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter/engine#40831)
2023-03-31 [email protected] Remove ios-release-nobitcode from
engine v2 builders. (flutter/engine#40830)
2023-03-31 [email protected] Add ui_web to embedder.yaml so that
the analyzer knows about it. (flutter/engine#40827)
2023-03-31 [email protected] Roll Skia from 2b86c6d364d0 to
33f80c07a09c (1 revision) (flutter/engine#40826)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
…sions) (flutter#123924)

Manual roll requested by [email protected]

flutter/engine@b2855e0...a48eedb

2023-04-01 [email protected] Revert "[web] Move text
editing nodes outside of shadowDOM" (flutter/engine#40847)
2023-04-01 [email protected] Roll Skia from 4d1e9cabf0c8 to
9973ef180f1f (2 revisions) (flutter/engine#40843)
2023-04-01 [email protected] Roll Dart SDK from
6ac8d3ad105f to 7e36e11608f3 (6 revisions) (flutter/engine#40842)
2023-04-01 [email protected] [Impeller] take advantage of native
decal sampling, blend cleanups (flutter/engine#40839)
2023-04-01 [email protected] Revert "[web] use callConstructor for
FinalizationRegistry due to bug… (flutter/engine#40841)
2023-04-01 [email protected] Revert "Add ui_web to
embedder.yaml so that the analyzer knows about it."
(flutter/engine#40840)
2023-04-01 [email protected] [Impeller] Migrate gaussian blur to
half precision. (flutter/engine#40800)
2023-03-31 [email protected] Roll Skia from 33f80c07a09c to
4d1e9cabf0c8 (3 revisions) (flutter/engine#40836)
2023-03-31 [email protected] [web] Move text
editing nodes outside of shadowDOM (flutter/engine#39688)
2023-03-31 [email protected] [web] Fix canvasKitVariant test
(flutter/engine#40833)
2023-03-31 [email protected] [web] use callConstructor for
FinalizationRegistry due to bug in dart2js (flutter/engine#40798)
2023-03-31 [email protected] Roll Fuchsia Mac SDK from
kiAbXJ_MIn6CAC9-C... to f16HBH4MJdaKy7Hlf... (flutter/engine#40831)
2023-03-31 [email protected] Remove ios-release-nobitcode from
engine v2 builders. (flutter/engine#40830)
2023-03-31 [email protected] Add ui_web to embedder.yaml so that
the analyzer knows about it. (flutter/engine#40827)
2023-03-31 [email protected] Roll Skia from 2b86c6d364d0 to
33f80c07a09c (1 revision) (flutter/engine#40826)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from kiAbXJ_MIn6C to f16HBH4MJdaK

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@mdebbar mdebbar deleted the fix_test branch June 22, 2023 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants