This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Include CPU blends + Flutter blend reference image in goldens #43117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of our advanced blends seem to still be wrong when the destination color is transparent as well... need to investigate. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 23, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 23, 2023
…129421) flutter/engine@aca26b2...27f3498 2023-06-23 [email protected] Roll Dart SDK from 7b30bcd6207e to 81cdbe69a16b (2 revisions) (flutter/engine#43138) 2023-06-23 [email protected] Roll ANGLE from 16d65289e868 to 9211ebf1f2ac (1 revision) (flutter/engine#43137) 2023-06-23 [email protected] Roll Skia from a94abf80dd2f to 6ab865ee1f65 (1 revision) (flutter/engine#43135) 2023-06-23 [email protected] Roll Fuchsia Linux SDK from tcVndpnH_jzGm5LsJ... to VSKvLPB4DCIDvXzOA... (flutter/engine#43134) 2023-06-23 [email protected] Roll ANGLE from ac4f52c4f7ff to 16d65289e868 (1 revision) (flutter/engine#43133) 2023-06-23 [email protected] Roll Skia from 450bc21cc836 to a94abf80dd2f (2 revisions) (flutter/engine#43132) 2023-06-23 [email protected] Roll ANGLE from 4ed2d403a329 to ac4f52c4f7ff (2 revisions) (flutter/engine#43130) 2023-06-23 [email protected] Roll Skia from a989b6f1aec5 to 450bc21cc836 (2 revisions) (flutter/engine#43128) 2023-06-23 [email protected] Removed outdated comment from lib/ui/canvas.h (flutter/engine#43112) 2023-06-23 [email protected] Roll Dart SDK from 05d99585adab to 7b30bcd6207e (1 revision) (flutter/engine#43123) 2023-06-23 [email protected] Roll Skia from 6595192c8352 to a989b6f1aec5 (1 revision) (flutter/engine#43120) 2023-06-23 [email protected] Roll Fuchsia Mac SDK from Ylc35wOk0_j0NLzDv... to 07vKo_Vaiy_Vw2xxb... (flutter/engine#43119) 2023-06-23 [email protected] [Impeller] Include CPU blends + Flutter blend reference image in goldens (flutter/engine#43117) 2023-06-23 [email protected] [Impeller] Fix and reland drawPaint collapsing optimization. (flutter/engine#43097) 2023-06-23 [email protected] Roll Skia from 5265b5ee1afc to 6595192c8352 (1 revision) (flutter/engine#43116) 2023-06-22 [email protected] Roll Dart SDK from ecca5857b3ba to 05d99585adab (4 revisions) (flutter/engine#43113) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from tcVndpnH_jzG to VSKvLPB4DCID fuchsia/sdk/core/mac-amd64 from Ylc35wOk0_j0 to 07vKo_Vaiy_V If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#128606.
Screen.Recording.2023-06-22.at.4.45.25.PM.mov