This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove WARNINGs from JNI load path as we can't suppress them #44348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jason-simmons
approved these changes
Aug 3, 2023
reidbaker
approved these changes
Aug 3, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2023
eyebrowsoffire
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 3, 2023
…131897) flutter/engine@b08e141...0c1de9b 2023-08-03 [email protected] [web] fix clicks on merged semantic nodes (flutter/engine#43620) 2023-08-03 [email protected] Remove WARNINGs from JNI load path as we can't suppress them (flutter/engine#44348) 2023-08-03 [email protected] Roll Skia from 872dc53233cf to bae32428c1c7 (3 revisions) (flutter/engine#44341) 2023-08-03 [email protected] Build iOS unittest target in unopt builds (flutter/engine#44301) 2023-08-03 [email protected] [darwin] Move common targets to common/BUILD.gn (flutter/engine#44335) 2023-08-03 [email protected] Roll Skia from 2babe68de295 to 872dc53233cf (2 revisions) (flutter/engine#44339) 2023-08-03 [email protected] Migrate GL calls of GrBackend* (flutter/engine#44334) 2023-08-03 [email protected] Roll Skia from 36072a994f11 to 2babe68de295 (1 revision) (flutter/engine#44336) 2023-08-03 [email protected] Roll Clang from 07c592048780 to 020d2fb7711d (flutter/engine#44332) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md --------- Co-authored-by: Zachary Anderson <[email protected]>
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…#44348) Help unblock roll
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help unblock roll