This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Introduce egl::Surface and egl::WindowSurface
#49983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
force-pushed
the
windows_egl_surface
branch
from
a261989 to
caf96e3
Compare
cbracken
reviewed
Jan 24, 2024
| @@ -14,7 +14,7 @@ namespace egl { | |||
|
|
|||
| // An EGL context to interact with OpenGL. | |||
| // | |||
| // This enables automatic eror logging and mocking. | |||
| // This enables automatic error logging and mocking. | |||
cbracken
reviewed
Jan 24, 2024
cbracken
approved these changes
Jan 24, 2024
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 25, 2024
…142202) flutter/engine@4880592...499ed00 2024-01-25 [email protected] Roll Skia from 3b7accdf8ed8 to 571873c31056 (1 revision) (flutter/engine#50026) 2024-01-25 [email protected] [Impeller] round up subpass coverage when it is close to (and smaller) than root pass size. (flutter/engine#49925) 2024-01-25 [email protected] Adding DDC module system targets to web SDK artifacts. (flutter/engine#47783) 2024-01-25 [email protected] [Windows] Set cursor immediately when framework requests update (flutter/engine#49784) 2024-01-25 [email protected] [Windows] Introduce `egl::Surface` and `egl::WindowSurface` (flutter/engine#49983) 2024-01-25 [email protected] Roll Skia from 588caf1ceddd to 3b7accdf8ed8 (1 revision) (flutter/engine#50025) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
loic-sharma
added
the
revert
|
Time to revert pull request flutter/engine/49983 has elapsed. |
auto-submit
bot
removed
the
revert
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
Jan 28, 2024
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
) # Original pull request description This introduces the `egl::Surface` and `egl::WindowSurface` types to abstract a raw `EGLSurface`. This also removes some - but not all - EGL surface logic out from `EGLManager`. Subsequent pull requests will be necessary to: 1. Move ownership of the `egl::WindowSurface` from `egl::Manager` to `FlutterWindowsView` 2. Refactor external texture's off-screen EGL surface to use `egl::Surface` Part of flutter/flutter#141996 # Reland #49983 was reverted as it introduced a crash if the render surface fails to be created even though EGL was initialized successfully. This pull request is split into the following commits: 1. c0b11be is the original pull request unchanged 2. 1dc7813 is the fix: it checks a surface is valid before using it. This also adds several tests to prevent this kind of regression. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
egl::Surfaceandegl::WindowSurfacetypes to abstract a rawEGLSurface. This also removes some - but not all - EGL surface logic out fromEGLManager.Subsequent pull requests will be necessary to:
egl::WindowSurfacefromegl::ManagertoFlutterWindowsViewegl::SurfacePart of flutter/flutter#141996
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.