This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland 4: Multiview pipeline #50931
Merged
Reland 4: Multiview pipeline #50931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Feb 23, 2024
dkwingsmt
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/50931, due to - The status or check suite Linux linux_android_emulator_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 24, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 24, 2024
…144083) flutter/engine@a148bdb...81035b7 2024-02-24 [email protected] Reland 4: Multiview pipeline (flutter/engine#50931) 2024-02-24 [email protected] Actually list all sources for scenario_app target. (flutter/engine#50933) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
54 tasks
dkwingsmt
added a commit
to dkwingsmt/engine
that referenced
this pull request
Feb 26, 2024
This reverts commit 81035b7.
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
This reverts commit 81035b7. Reason: Internal test failure blocking roll OCL:610420483:BASE:610486571:1708978396098:f2c3c31 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
dkwingsmt
added a commit
that referenced
this pull request
Feb 27, 2024
This was referenced Feb 27, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
This relands #50931. The crash that caused the 4th revert has been fixed by flutter/flutter#144212. [There has been discussion](#51019) on why the benchmark in previous attempts show significant drop in build time. This PR addresses it using option a as described in [this comment](#51186 (comment)). This PR also addresses flutter/flutter#144584 with option 1. A test is added. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relands #49950.
Nothing is changed. The error turns out a flake (it passes once), although this PR might have made the flake more flaky.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.