Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Enable gtest-parallel for Impeller unit tests #52004

Merged
merged 1 commit into from
Apr 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions testing/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,10 @@ def __str__(self):
'--gtest_shuffle',
]

repeat_flags = [
'--repeat=2',
]


def run_cc_tests(build_dir, executable_filter, coverage, capture_core_dump):
logger.info('Running Engine Unit-tests.')
Expand All @@ -393,10 +397,6 @@ def run_cc_tests(build_dir, executable_filter, coverage, capture_core_dump):
import resource # pylint: disable=import-outside-toplevel
resource.setrlimit(resource.RLIMIT_CORE, (resource.RLIM_INFINITY, resource.RLIM_INFINITY))

repeat_flags = [
'--repeat=2',
]

def make_test(name, flags=None, extra_env=None):
if flags is None:
flags = repeat_flags
Expand Down Expand Up @@ -507,9 +507,10 @@ def make_test(name, flags=None, extra_env=None):
)
extra_env = metal_validation_env()
extra_env.update(vulkan_validation_env(build_dir))
mac_impeller_unittests_flags = shuffle_flags + [
mac_impeller_unittests_flags = repeat_flags + [
'--gtest_filter=-*OpenGLES', # These are covered in the golden tests.
'--',
'--enable_vulkan_validation',
'--gtest_filter=-*OpenGLES' # These are covered in the golden tests.
]
# Impeller tests are only supported on macOS for now.
run_engine_executable(
Expand All @@ -519,6 +520,7 @@ def make_test(name, flags=None, extra_env=None):
mac_impeller_unittests_flags,
coverage=coverage,
extra_env=extra_env,
gtest=True,
# TODO(https://github.com/flutter/flutter/issues/123733): Remove this allowlist.
# See also https://github.com/flutter/flutter/issues/114872.
allowed_failure_output=[
Expand Down Expand Up @@ -1272,9 +1274,10 @@ def main():
build_dir,
'impeller_unittests',
engine_filter,
shuffle_flags,
repeat_flags,
coverage=args.coverage,
extra_env=extra_env
extra_env=extra_env,
gtest=True
)
finally:
xvfb.stop_virtual_x(build_name)
Expand Down