This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix CkBrowserImageDecoder conversion of images to ImageByteFormat.rawRgba and rawStraightRgba #52089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Rgba and rawStraightRgba VideoFrames of decoded images typically contain BGRA format. The CkBrowserImageDecoder implementation of toByteData needs to convert that into RGBA format. If the output format is rawRgba then it also needs to apply premultipled alpha. Also fixes an issue where _bgrToRgba was not converting all pixels in the image. Fixes flutter/flutter#135409 Fixes flutter/flutter#144770
yjbanov
approved these changes
Apr 12, 2024
| } | ||
|
|
||
| /// Based on Chromium's SetRGBAPremultiply. | ||
| int _premultiply(int value, int alpha) { |
There was a problem hiding this comment.
It might make sense to inline this function using @pragma('dart2js:tryInline') as images can be pretty big and could take advantage of faster pixel processing logic.
There was a problem hiding this comment.
Added the inlining annotation
| } | ||
|
|
||
| // Last resort, just return the original pixels. | ||
| return pixels.asByteData(); | ||
| } | ||
|
|
||
| /// Mutates the [pixels], converting them from BGRX/BGRA to RGBA. | ||
| void _bgrToRgba(ByteBuffer pixels) { | ||
| final int pixelCount = pixels.lengthInBytes ~/ 4; | ||
| void _bgrToStraightRgba(ByteBuffer pixels, bool isBgrx) { |
There was a problem hiding this comment.
This could be inlined too so that the compiler specializes the function for possible values of isBgrx, true and false.
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2024
…Format.rawRgba and rawStraightRgba (flutter/engine#52089)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2024
…146959) flutter/engine@624730f...725ebd7 2024-04-17 [email protected] Roll Skia from 5958cd52db48 to a3a016537a8c (3 revisions) (flutter/engine#52208) 2024-04-17 [email protected] Roll Dart SDK from bd7627bca67b to 45dd87c2329c (1 revision) (flutter/engine#52207) 2024-04-17 [email protected] Fix CkBrowserImageDecoder conversion of images to ImageByteFormat.rawRgba and rawStraightRgba (flutter/engine#52089) 2024-04-17 [email protected] Roll Skia from a78dec0c0538 to 5958cd52db48 (2 revisions) (flutter/engine#52206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146959) flutter/engine@624730f...725ebd7 2024-04-17 [email protected] Roll Skia from 5958cd52db48 to a3a016537a8c (3 revisions) (flutter/engine#52208) 2024-04-17 [email protected] Roll Dart SDK from bd7627bca67b to 45dd87c2329c (1 revision) (flutter/engine#52207) 2024-04-17 [email protected] Fix CkBrowserImageDecoder conversion of images to ImageByteFormat.rawRgba and rawStraightRgba (flutter/engine#52089) 2024-04-17 [email protected] Roll Skia from a78dec0c0538 to 5958cd52db48 (2 revisions) (flutter/engine#52206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VideoFrames of decoded images typically contain BGRA format. The CkBrowserImageDecoder implementation of toByteData needs to convert that into RGBA format. If the output format is rawRgba then it also needs to apply premultipled alpha.
Also fixes an issue where _bgrToRgba was not converting all pixels in the image.
Fixes flutter/flutter#135409
Fixes flutter/flutter#144770