Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Suppress in-actionable warnings in the iOS profiler. #52227

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Suppress in-actionable warnings in the iOS profiler. #52227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d359ea5
Suppress in-actionable warnings in the iOS profiler.
chinmaygarde Apr 18, 2024
adf204a
Fix build.
chinmaygarde Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions shell/platform/darwin/ios/framework/Source/profiler_metrics_ios.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
MachThreads() = default;

~MachThreads() {
kern_return_t kernel_return_code = vm_deallocate(
[[maybe_unused]] kern_return_t kernel_return_code = vm_deallocate(
mach_task_self(), reinterpret_cast<vm_offset_t>(threads), thread_count * sizeof(thread_t));
FML_CHECK(kernel_return_code == KERN_SUCCESS) << "Failed to deallocate thread infos.";
FML_DCHECK(kernel_return_code == KERN_SUCCESS) << "Failed to deallocate thread infos.";
}

private:
Expand Down Expand Up @@ -165,8 +165,6 @@ void DeleteIO(io_object_t value) {
kernel_return_code =
task_threads(mach_task_self(), &mach_threads.threads, &mach_threads.thread_count);
if (kernel_return_code != KERN_SUCCESS) {
FML_LOG(ERROR) << "Error retrieving task information: "
<< mach_error_string(kernel_return_code);
return std::nullopt;
}

Expand Down Expand Up @@ -203,8 +201,6 @@ void DeleteIO(io_object_t value) {
num_threads--;
break;
default:
FML_LOG(ERROR) << "Error retrieving thread information: "
<< mach_error_string(kernel_return_code);
return std::nullopt;
}
}
Expand All @@ -223,8 +219,6 @@ void DeleteIO(io_object_t value) {
task_info(mach_task_self(), TASK_VM_INFO, reinterpret_cast<task_info_t>(&task_memory_info),
&task_memory_info_count);
if (kernel_return_code != KERN_SUCCESS) {
FML_LOG(ERROR) << " Error retrieving task memory information: "
<< mach_error_string(kernel_return_code);
return std::nullopt;
}

Expand Down