[Impeller] Reland: Compute UVs in vertex stage. #52303
Conversation
…gine into compute_uv_vertex_stage
|
Goldens have revealed that the vertices changes were incorrect |
|
Reverted the changes to vertices_contents, expecting a clean bill of golden health. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Ahh OK - one more problem. We can optimize vertices contents into regular contents, will need to untangle that too. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Ahh, but the vertices UV assumes that is handled... Looks like I'm going to have to pull forward some refactors I had planned on doing later. Basically we need to separate out drawVertices and drawAtlas since they work differently from our regular drawing (or they should). |
|
Golden file changes are available for triage from new commit, Click here to view. |
In order to land #52303 , we need to finally fix the advanced blend draw vertices combo. Right now a ColorFilter is used for advanced blends which doesn't work if there are overlapping vertices. See also: flutter/flutter#145707 The issue was fixed for drawVertices/drawAtlas pipeline blends using the porterduff shader. This extends this to advanced blends, but since drawVertices/atlas with an advanced blend is uncommon and because we don't 15 new shader variants, just add one special uber shader. Part of flutter/flutter#131345
|
Golden file changes are available for triage from new commit, Click here to view. |
|
There are still some golden diffs but these are now rendering correctly instead of incorrectly! |
jonahwilliams
added
the
autosubmit
…147267) flutter/engine@d56a231...9819627 2024-04-23 [email protected] Roll Dart SDK from 6a670b60eb06 to cf9144942ca1 (1 revision) (flutter/engine#52338) 2024-04-23 [email protected] [Impeller] Reland: Compute UVs in vertex stage. (flutter/engine#52303) 2024-04-23 [email protected] [Impeller] Add DriverInfoVK::IsEmulator and a log dumper for driver info. (flutter/engine#52337) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Compute texture UVs in the vertex stage. Reland of #52106 which was reverted to investigate golden failures during the x64 to arm64 mac switch.