Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Replace Impeller opacity peephole delegate with DL variant. #52707

Merged
merged 15 commits into from
May 31, 2024
Merged

[Impeller] Replace Impeller opacity peephole delegate with DL variant. #52707

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9bdf84b
[Impeller] test DL opacity peephole.
jonahwilliams May 10, 2024
6deb635
Merge branch 'main' of github.com:flutter/engine into peephole_exp_ca…
jonahwilliams May 14, 2024
3d5739a
Delete impeller opacity peephole.
jonahwilliams May 14, 2024
326af19
++
jonahwilliams May 15, 2024
d66b1a3
add test and port existing opacity test.
jonahwilliams May 15, 2024
03f4ffb
Merge branch 'main' of github.com:flutter/engine into peephole_exp_ca…
jonahwilliams May 28, 2024
0d36fe0
updates to check paint state.
jonahwilliams May 28, 2024
6a1a416
Merge branch 'main' of github.com:flutter/engine into peephole_exp_ca…
jonahwilliams May 30, 2024
55ad6ee
fix missing default value.
jonahwilliams May 31, 2024
74f8f84
license
jonahwilliams May 31, 2024
49c7376
update goldens.
jonahwilliams May 31, 2024
302e125
fix distribution to save layers and add unit tests.
jonahwilliams May 31, 2024
06ca207
update impeller goldens.
jonahwilliams May 31, 2024
88cd532
Update impeller_golden_tests_output.txt
jonahwilliams May 31, 2024
1f90efb
Update aiks_dl_opacity_unittests.cc
jonahwilliams May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion impeller/display_list/dl_dispatcher.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,7 +1030,8 @@ void DlDispatcherBase::drawDisplayList(
save_paint.color = Color(0, 0, 0, opacity);
GetCanvas().SaveLayer(
save_paint, skia_conversions::ToRect(display_list->bounds()), nullptr,
ContentBoundsPromise::kContainsContents, display_list->total_depth());
ContentBoundsPromise::kContainsContents, display_list->total_depth(),
display_list->can_apply_group_opacity());
} else {
// The display list may alter the clip, which must be restored to the
// current clip at the end of playback.
Expand Down