Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[DisplayList] delete obsolete PathEffect sources #53441

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

flar
Copy link
Contributor

@flar flar commented Jun 17, 2024

As of #53411 there are no more (non-test) references to path effects anywhere in the engine.

Deleting the dead code.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2024
@auto-submit auto-submit bot merged commit 74f42ca into flutter:main Jun 18, 2024
33 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 18, 2024
…150421)

flutter/engine@78fdd06...74f42ca

2024-06-18 [email protected] [DisplayList] delete obsolete PathEffect sources (flutter/engine#53441)
2024-06-18 [email protected] Setup `NativeAssetsApi` during isolate group creation (flutter/engine#53329)
2024-06-18 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.6 to 4.1.7 (flutter/engine#53445)
2024-06-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.8 to 3.25.10 (flutter/engine#53446)
2024-06-18 [email protected] Roll Skia from f18547e60ed8 to 6d541b4dddd0 (1 revision) (flutter/engine#53444)
2024-06-18 [email protected] Roll Skia from 2db8813a349d to f18547e60ed8 (1 revision) (flutter/engine#53442)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants