Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. #53720

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. #53720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions shell/platform/embedder/embedder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,14 @@ typedef struct {
} FlutterOpenGLTexture;

typedef struct {
/// The target of the color attachment of the frame-buffer. For example,
/// GL_TEXTURE_2D or GL_RENDERBUFFER. In case of ambiguity when dealing with
/// Window bound frame-buffers, 0 may be used.
/// The format of the color attachment of the frame-buffer. For example,
/// GL_RGBA8.
///
/// In case of ambiguity when dealing with Window bound frame-buffers, 0 may
/// be used.
///
/// @bug This field is incorrectly named as "target" when it actually
/// refers to a format.
uint32_t target;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably treading on thin ice, but I wonder if we could play games using a union here to create a parallel struct with the correct name? We'd need to keep the two structs in sync though.


/// The name of the framebuffer.
Expand Down