This repository was archived by the owner on Feb 25, 2025. It is now read-only.
web_ui: bump min Dart SDK to 3.6.0-0 #54626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed two unused dev dependencies Enables usage of `Since` in dart:js_interop
srujzs
approved these changes
Aug 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 20, 2024
…153733) flutter/engine@9d7e3a6...7dd71ff 2024-08-19 [email protected] web_ui: bump min Dart SDK to 3.6.0-0 (flutter/engine#54626) 2024-08-19 [email protected] [Impeller] Add a note about Graphite to the FAQ. (flutter/engine#54623) 2024-08-19 [email protected] [skwasm] Fix skwasm clip coverage algorithm. (flutter/engine#54572) 2024-08-19 [email protected] Roll Skia from 318b7958f748 to b6224c9e6611 (2 revisions) (flutter/engine#54625) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 20, 2024
This reverts commit 7600900. Reason for revert: flutter/engine#54626 has update the pubspecs for web_ui and web_sdk to include `3.6`. Original change's description: > Revert "[dart:js_interop] Add Since('3.6') annotations to new APIs" > > This reverts commit 14cf3b4. > > Reason for revert: web_ui uses some of these APIs, but the pubspec SDK version is not >= 3.6. Therefore, Flutter analyze fails, which would then result in a broken roll. Updating the pubspec versions leads to try bot failures (flutter/engine#54590) so for now, revert. > > Original change's description: > > [dart:js_interop] Add Since('3.6') annotations to new APIs > > > > Closes #56484 > > > > Change-Id: I9d3da568aafeccbb855892ea5c2ba647371170bc > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380900 > > Reviewed-by: Kevin Moore <[email protected]> > > Reviewed-by: Leaf Petersen <[email protected]> > > Reviewed-by: Sigmund Cherem <[email protected]> > > Commit-Queue: Srujan Gaddam <[email protected]> > > Reviewed-by: Martin Kustermann <[email protected]> > > Change-Id: Idfb021c5744d83a8004259f9c8774945a2612efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380967 > Reviewed-by: Leaf Petersen <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Commit-Queue: Srujan Gaddam <[email protected]> Change-Id: I5c37640e06456d270db2adfd70283456bde671ce Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381308 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Kevin Moore <[email protected]> Commit-Queue: Srujan Gaddam <[email protected]>
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153733) flutter/engine@9d7e3a6...7dd71ff 2024-08-19 [email protected] web_ui: bump min Dart SDK to 3.6.0-0 (flutter/engine#54626) 2024-08-19 [email protected] [Impeller] Add a note about Graphite to the FAQ. (flutter/engine#54623) 2024-08-19 [email protected] [skwasm] Fix skwasm clip coverage algorithm. (flutter/engine#54572) 2024-08-19 [email protected] Roll Skia from 318b7958f748 to b6224c9e6611 (2 revisions) (flutter/engine#54625) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed two unused dev dependencies
Enables usage of
Sincein dart:js_interop